feat: Add set node account id method #362

aceppaluni · 2025-09-08T16:27:04Z

Description:
Add Set_node_account_ids() method to Query and Transaction for retrieving receipts or records.

Added methods to both Query and Transaction
Added unit test for Query
Added unit test for Transaction

Related issue(s):

Fixes #86

Notes for reviewer:
Ran tests for both Query and Transaction

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Angelina <aceppaluni@gmail.com>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

exploreriii

Hi @accepaluni please remember to pre-fix your PR title eg
feat: add set node account id method
additionally, we now have a changelog, which must be updated with each PR

src/hiero_sdk_python/transaction/transaction.py

nadineloepfe · 2025-10-06T14:49:00Z

Hi @aceppaluni,
are you still working on this?
also, would you mind adding a "feat:" in front of your PR title as well as an entry in the CHANGELOG? thanks

aceppaluni · 2025-10-14T21:29:41Z

Hi @nadineloepfe Yes, my apologies.
I have been a bit busier then normal. Of course, will do, thank you!

exploreriii · 2025-12-04T11:15:18Z

Please push the new changes if you are happy with them and lets run the tests here 👍

aceppaluni · 2025-12-04T13:40:04Z

@exploreriii I pushed the changes and it corrected those first few failing tests. Seems as though another is failing : test_query_retry_on_busy

aceppaluni · 2025-12-04T16:45:20Z

Hi! @nadineloepfe @exploreriii ,
I did a copy/paste of the test_executable.py method and I cannot get the test_query_retry_busy test to pass.

exploreriii

@aceppaluni looking at https://github.com/hiero-ledger/hiero-sdk-python/pull/362/files
it is clear that you've not added the new functionality, please try to copy/paste it again now that a rebase isn't required, it should work easier
There are also errors such as deleted lines from a rebase - sorry!!

aceppaluni · 2025-12-04T19:12:23Z

@exploreriii
Hmm, thats interesting. I wonder if maybe I should have copied more then just query and executable?
And no worries! Rebases are definitely tricky for me.

exploreriii · 2025-12-04T20:29:18Z

try it again please and see if it works 👍
You can see in /files, query and executable look very different to Nadine's version

exploreriii

So some of the content in the PR differs from Nadine's pR
https://github.com/hiero-ledger/hiero-sdk-python/pull/853/files#diff-0600439f79ba6386f80cba2dba2dfebdf084869ebbf9943cc3eaf0cad9fd013a
not sure how that happened, but it is different
Some files are the same, meaning maybe only some things were copied over?

exploreriii · 2025-12-07T19:00:03Z

src/hiero_sdk_python/query/query.py

        self.operator = self.operator or client.operator
-        self.node_account_ids = list(set(self.node_account_ids))

+        if not getattr(self, "node_account_ids", None):


i notice you have added line 110 to 112 compared to Nadine's version

exploreriii · 2025-12-07T19:01:49Z

src/hiero_sdk_python/transaction/transaction.py

        # and ensures that the correct signatures are used when submitting transactions
        self._signature_map: dict[bytes, basic_types_pb2.SignatureMap] = {}
        # changed from int: 2_000_000 to Hbar: 0.02
        self._default_transaction_fee = Hbar(0.02)


all this section is different to Nadine's version too

def __init__(self) -> None: """ Initializes a new Transaction instance with default values. """ super().__init__() self.transaction_id = None self.transaction_fee: int | None = None self.transaction_valid_duration = 120 self.generate_record = False self.memo = "" self.custom_fee_limits: list[CustomFeeLimit] = [] # Maps each node's AccountId to its corresponding transaction body bytes # This allows us to maintain separate transaction bodies for each node # which is necessary in case node is unhealthy and we have to switch it with other node. # Each transaction body has the AccountId of the node it's being submitted to. # If these do not match `INVALID_NODE_ACCOUNT` error will occur. self._transaction_body_bytes: dict[AccountId, bytes] = {} # Maps transaction body bytes to their associated signatures # This allows us to maintain the signatures for each unique transaction # and ensures that the correct signatures are used when submitting transactions self._signature_map: dict[bytes, basic_types_pb2.SignatureMap] = {} self._default_transaction_fee = 2_000_000 self.operator_account_id = None self.batch_key: Optional[PrivateKey] = None

aceppaluni · 2025-12-07T20:25:09Z

@exploreriii I've copied the files but the workflow is not passing locally.

exploreriii · 2025-12-07T21:29:04Z

ok, would suggest to push so we can see what is going on

Signed-off-by: Angelina <aceppaluni@gmail.com>

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

Signed-off-by: Angelina <aceppaluni@gmail.com>

github-actions · 2025-12-08T17:00:55Z

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

DCO signing guide
Changelog guide
Merge conflicts guide
Rebase guide
Testing guide
Discord
Community Calls
Thank you for contributing!
From the Hiero Python SDK Team

aceppaluni · 2025-12-08T17:14:28Z

@nadineloepfe We are now down to one failing check. I am not certain as to why as the files were copied the same.

nadineloepfe · 2025-12-09T10:45:39Z

Hi @aceppaluni :
I hope it's ok that this has been merged now:
#1020

you're commits have been preserved, so you still got the sign off for your work. I therefore close this PR now.
Thank you so much! :)

aceppaluni · 2025-12-09T13:07:29Z

@nadineloepfe Thank you!

Could you tell me what was done to fix the final check? I am trying to take a look but only see changes to the CHANGELOG and had wanted to take it as a learning opportunity :)

aceppaluni and others added 21 commits May 22, 2025 10:26

add tokenInfoQuery functionality

f694268

Signed-off-by: Angelina <aceppaluni@gmail.com>

refactor: update TokenInfoQuery implementation

d5310c8

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add unit tests

76b0d85

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add integration tests

256e807

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: add examples for both non-fungible/fungible tokens

32443f1

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update README in examples

3c3a6ea

Signed-off-by: dosi <dosi.kolev@limechain.tech>

chore: add TokenInfoQuery to __init__.py

1a453ee

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: reduce test_token_info_query_execute function length

1c6ac60

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: fix incorrect integration test function names

df1069c

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: change network from solo to testnet and some minor changes in e…

67c9eb7

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: address PR comments for integration/unit tests

d7d6c18

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update examples for TokenInfoQuery to address PR comments

79c1f10

Signed-off-by: dosi <dosi.kolev@limechain.tech>

Merge branch 'hiero-ledger:main' into main

a4372ad

Merge branch 'hiero-ledger:main' into main

17ace16

Merge branch 'hiero-ledger:main' into main

090b2bb

Merge branch 'hiero-ledger:main' into main

854c0ca

Merge branch 'hiero-ledger:main' into main

168d706

Merge branch 'hiero-ledger:main' into main

143b727

Merge branch 'hiero-ledger:main' into main

ad6df88

Merge branch 'hiero-ledger:main' into main

fdcc0cb

Merge branch 'hiero-ledger:main' into main

b9ad245

aceppaluni marked this pull request as ready for review September 9, 2025 14:24

exploreriii requested changes Sep 9, 2025

View reviewed changes

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

Merge branch 'hiero-ledger:main' into main

7f4ee47

Merge branch 'hiero-ledger:main' into main

e17c504

aceppaluni changed the title ~~Add set node account id method~~ feat: Add set node account id method Oct 20, 2025

aceppaluni added 2 commits October 20, 2025 18:42

Merge branch 'hiero-ledger:main' into main

22ba822

Merge branch 'hiero-ledger:main' into main

2741bde

exploreriii requested changes Dec 4, 2025

View reviewed changes

exploreriii mentioned this pull request Dec 7, 2025

feat(github-actions): add inactivity bot phase 2 (stale PR detection) #989

Merged

exploreriii reviewed Dec 7, 2025

View reviewed changes

exploreriii marked this pull request as draft December 7, 2025 21:29

aceppaluni and others added 13 commits December 8, 2025 11:21

Merge branch 'hiero-ledger:main' into main

cfce2d7

Add set_node_account_id method

a58d94d

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix: add missing List import and update changelog

511823f

Signed-off-by: Angelina <aceppaluni@gmail.com>

style: add spacing in set_node_account_id method

294b56c

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: support selecting node account ID for execution flow

1048888

Signed-off-by: Angelina <aceppaluni@gmail.com>

Fix node selection to use _select_node instead of _get_node

01ab04b

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: add Network._get_node() and update executable to support node s…

c783232

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: move node account ID selection to _Executable and update execut…

ee5d3d6

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

Fix imports for List and AccountId; update executable; sync with main

9efb2a0

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix: node array selection

19a57b8

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix: update changelog entry

1248c8d

Signed-off-by: Angelina <aceppaluni@gmail.com>

Fix Query._before_execute node setup and execution node selection

eeaeed4

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix:updating file changes

c60399f

Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from a0f96ad to c60399f Compare December 8, 2025 16:41

nadineloepfe closed this Dec 9, 2025

feat: Add set node account id method #362

feat: Add set node account id method #362

Conversation

aceppaluni commented Sep 8, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nadineloepfe commented Oct 6, 2025

Uh oh!

aceppaluni commented Oct 14, 2025

Uh oh!

exploreriii commented Dec 4, 2025

Uh oh!

aceppaluni commented Dec 4, 2025

Uh oh!

aceppaluni commented Dec 4, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Dec 4, 2025

Uh oh!

exploreriii commented Dec 4, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

exploreriii Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

exploreriii Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Dec 7, 2025

Uh oh!

exploreriii commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

aceppaluni commented Dec 8, 2025

Uh oh!

nadineloepfe commented Dec 9, 2025

Uh oh!

aceppaluni commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aceppaluni commented Dec 9, 2025 •

edited

Loading